Project

General

Profile

Actions
Copy link

Maintenance #3055

closed

xmera Omnia - Collection #3085: Maintain several plugins to be compatible

(rm 5.1.7): Consider changes in views/queries/_form.html.erb

Added by liaham 23 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
liaham
Target version:
4.6.1
Start date:
03/16/2025
Due date:
03/16/2025
% Done:

100%

Estimated time:
Compatible Redmine Version:
5.1.z
Pull Request Link:
n/a

Description

diff --git a/app/views/queries/_form.html.erb b/app/views/queries/_form.html.erb
index d1c1ef31f..1c302fe76 100644
--- a/app/views/queries/_form.html.erb
+++ b/app/views/queries/_form.html.erb
@@ -4,7 +4,6 @@
 <div class="tabular">
 <%= hidden_field_tag 'gantt', '1' if params[:gantt] %>
 <%= hidden_field_tag 'calendar', '1' if params[:calendar] %>
-<%= hidden_field_tag 'admin_projects', '1' if params[:admin_projects] %>
 
 <p>
   <label for="query_name">
@@ -19,7 +18,7 @@
 <p><label><%=l(:field_visible)%></label>
   <label class="block"><%= radio_button 'query', 'visibility', Query::VISIBILITY_PRIVATE %> <%= l(:label_visibility_private) %></label>
   <label class="block"><%= radio_button 'query', 'visibility', Query::VISIBILITY_PUBLIC %> <%= l(:label_visibility_public) %></label>
-  <% unless @query.type == 'ProjectQuery' %>
+  <% unless @query.is_a?(ProjectQuery) %>
     <label class="block"><%= radio_button 'query', 'visibility', Query::VISIBILITY_ROLES %> <%= l(:label_visibility_roles) %>:</label>
       <% Role.givable.sorted.each do |role| %>
         <label class="block role-visibility"><%= check_box_tag 'query[role_ids][]', role.id, @query.roles.include?(role), :id => nil %> <%= role.name %></label>
@@ -29,7 +28,7 @@
 </p>
 <% end %>
 
-<% unless @query.type == 'ProjectQuery' %>
+<% unless @query.is_a?(ProjectQuery) %>
   <p><label for="query_is_for_all"><%=l(:field_is_for_all)%></label>
   <%= check_box_tag 'query_is_for_all', 1, @query.project.nil?, :class => (User.current.admin? ? '' : 'disable-unless-private') %></p>
 <% end %>
Actions
Copy link
 #1

Updated by liaham 23 days ago

  • Subject changed from Consider views/queries/_form.html.erb to Check views/queries/_form.html.erb
Actions
Copy link
 #2

Updated by liaham 20 days ago

  • Project changed from Redmine to Redmine Project Types
  • Subject changed from Check views/queries/_form.html.erb to Consider changes in views/queries/_form.html.erb
  • Assignee set to liaham
  • Target version changed from 5.1.7 to 4.6.1
Actions
Copy link
 #3

Updated by liaham 19 days ago

  • Due date set to 03/16/2025
  • Status changed from New to Closed
  • Start date set to 03/16/2025
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by liaham 19 days ago

  • Subject changed from Consider changes in views/queries/_form.html.erb to (rm 5.1.7): Consider changes in views/queries/_form.html.erb
Actions
Copy link
 #5

Updated by liaham 18 days ago

  • Parent task set to #3085
Actions
Copy link

Also available in: Atom PDF