Project

General

Profile

Actions

Maintenance #2649

closed

xmera Omnia - Collection #2546: Third-Party module maintenance and bug-fixing

Maintenance #2617: Redmine 5.1.4

Check changes in /app/models/query.rb

Added by liaham 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
11/13/2024
Due date:
11/13/2024
% Done:

100%

Estimated time:
Compatible Redmine Version:
5.1.z, 6.0.z

Description

  • ./plugins/redmine_project_types_relations/lib/project_types_relations/overrides/project_type_query_patch.rb
  • ./plugins/redmine_project_types_relations/lib/project_types_relations/overrides/project_query_patch.rb
  • ./plugins/redmine_project_types/lib/project_types/overrides/project_query_patch.rb
  • ./plugins/redmine_project_types/lib/project_types/overrides/query_patch.rb
  • ./plugins/redmine_project_types/lib/project_types/extensions/project_query_patch.rb
  • ./plugins/redmine_colored_enumeration/lib/colored_enumeration/extensions/query_custom_field_column_patch.rb
diff --git a/app/models/query.rb b/app/models/query.rb
index fcd2c9e95..980976e5f 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -618,7 +618,7 @@ class Query < ActiveRecord::Base
     author_values = []
     author_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
     author_values +=
-      users.sort_by(&:status).
+      users.sort_by{|p| [p.status, p]}.
         collect{|s| [s.name, s.id.to_s, l("status_#{User::LABEL_BY_STATUS[s.status]}")]}
     author_values << [l(:label_user_anonymous), User.anonymous.id.to_s]
     author_values
@@ -628,7 +628,7 @@ class Query < ActiveRecord::Base
     assigned_to_values = []
     assigned_to_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
     assigned_to_values +=
-      (Setting.issue_group_assignment? ? principals : users).sort_by(&:status).
+      (Setting.issue_group_assignment? ? principals : users).sort_by{|p| [p.status, p]}.
         collect{|s| [s.name, s.id.to_s, l("status_#{User::LABEL_BY_STATUS[s.status]}")]}
     assigned_to_values
   end
@@ -658,7 +658,7 @@ class Query < ActiveRecord::Base
     watcher_values = [["<< #{l(:label_me)} >>", "me"]]
     if User.current.allowed_to?(:view_issue_watchers, self.project, global: true)
       watcher_values +=
-        principals.sort_by(&:status).
+        principals.sort_by{|p| [p.status, p]}.
           collect{|s| [s.name, s.id.to_s, l("status_#{User::LABEL_BY_STATUS[s.status]}")]}
     end
     watcher_values
Actions #1

Updated by liaham 5 months ago

  • Description updated (diff)
  • Due date set to 11/13/2024
  • Status changed from New to Closed
  • Assignee set to liaham
  • Start date set to 11/13/2024
  • % Done changed from 0 to 100

Checked all patches. There is no code affected by the latest changes of RM.

Actions

Also available in: Atom PDF