Project

General

Profile

Actions

Bug #2619

closed

xmera Omnia - Collection #2546: Third-Party module maintenance and bug-fixing

Plugin settings of data type boolean do not work properly

Added by liaham 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Affected Version:
Compatible Redmine Version:
5.1.z

Description

We observed when dmsf_display_notified_recipients is nil no notified recipients will be displayed. But as soon as someone changes the value to true and back again to false recipients will still be displayed. This may be caused by storing false as empty string instead of nil in :settings table.

This effect may concern other boolean plugin settings as well and needs to be investigated.

Actions #1

Updated by liaham 4 months ago

  • Target version changed from 3.2.4 to unreleased
Actions #2

Updated by liaham 4 months ago

  • Target version changed from unreleased to 3.2.5-xmr
Actions #3

Updated by liaham 4 months ago

  • Parent task set to #2546
Actions #4

Updated by liaham 4 months ago · Edited

These are all settings with default values. Some of them act as boolean:

             'dmsf_max_file_download' => 0,
             'dmsf_max_email_filesize' => 0,
             'dmsf_storage_directory' => 'files/dmsf',
             'dmsf_index_database' => File.expand_path('dmsf_index', Rails.root),
             'dmsf_stemming_lang' => 'english',
             'dmsf_stemming_strategy' => 'STEM_NONE',
             'dmsf_webdav' => webdav,
             'dmsf_display_notified_recipients' => nil,
             'dmsf_global_title_format' => '',
             'dmsf_columns' => %w[title size modified version workflow author],
             'dmsf_webdav_ignore' => '^(\._|\.DS_Store$|Thumbs.db$)',
             'dmsf_webdav_disable_versioning' => '^\~\$|\.tmp$',
           'dmsf_keep_documents_locked' => nil, ==> false or removed entirely
           'dmsf_act_as_attachable' => nil, => true or entirely removed
             'dmsf_documents_email_from' => '',
             'dmsf_documents_email_reply_to' => '',
           'dmsf_documents_email_links_only' => nil, => true or removed entirely
           'dmsf_enable_cjk_ngrams' => nil,  => true or removed entirely
           'dmsf_webdav_use_project_names' => use_project_names,  => true or removed entirely
           'dmsf_webdav_ignore_1b_file_for_authentication' => '1',  => true or removed entirely
           'dmsf_projects_as_subfolders' => nil,  => true or removed entirely
           'only_approval_zero_minor_version' => '0',  => false or removed entirely
             'dmsf_max_notification_receivers_info' => 10,
             'office_bin' => 'libreoffice',
           'dmsf_global_menu_disabled' => nil,  => true or removed entirely
             'dmsf_default_query' => nil,
           'empty_minor_version_by_default' => nil, ==> false or removed entirely
           'remove_original_documents_module' => nil, => false or removed entirely
             'dmsf_webdav_authentication' => 'Digest'
  • ✅ dmsf_really_delete_files => 0 or entirely removed
Actions #5

Updated by liaham 4 months ago · Edited

There is a github PR for dmsf_display_notified_recipients: https://github.com/danmunn/redmine_dmsf/pull/1565. It is cherry-picked.

Actions #6

Updated by liaham 4 months ago

All other settings are working as expected.

Actions #7

Updated by liaham 4 months ago

  • Status changed from New to Closed
  • Assignee set to liaham
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF