Improvement #2475
closedAdds further text to reset button of webdav digest
100%
Description
When a user has 2FA enabled the WebDAV digest won't be created on sign in.
The reason is in RedmineDmsf::Hooks::Controllers::AccountControllerHooks#controller_account_success_authentication_after
where the digest will be created only if the controller parameter password
is present. This works for a user authentication with login name and password. A user with 2fa enabled runs differently through the authentication process and crosses the hook not before the 2fa token was checked. Hence, there won't be a password parameter anymore.
Instead of manipulating controller params to provide the password I suggest only a slight change in the users preferences box on my account page:
When the user has 2FA enabled and no token is found the link should not show reset
but add
. This would make it more explicit that the token is not expected to exist and can be created if missing.
Updated by liaham 6 months ago
- Tracker changed from Bug to Improvement
- Subject changed from WebDAV digest won't be created if 2FA is enabled to Adds further text to reset button of webdav digest
- Status changed from New to Feedback
- Pull Request Link changed from n/a to https://github.com/danmunn/redmine_dmsf/pull/1552
- Affected Version deleted (
3.2.1)