Project

General

Profile

Actions
Copy link

Maintenance #2172

closed

Collection #1826: Maintenance tasks of several components

Maintenance #2123: Support Redmine 5.1.3

Fix broken integration tests

Added by liaham 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
liaham
Target version:
4.3.0
Start date:
Due date:
% Done:

100%

Estimated time:
Affected component:
Compatible Redmine Version:
Pull Request Link:

Description

FAIL ProjectsTest#test_archive_project (6.45s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/projects_test.rb:29:in `test_archive_project'

FAIL HookTest#test_empty_sidebar_should_be_hidden (18.28s)
        Expected at least 1 element matching "div#main.nosidebar", found 0.
        Expected 0 to be >= 1.
        test/integration/lib/redmine/hook_test.rb:86:in `test_empty_sidebar_should_be_hidden'

 FAIL HookTest#test_sidebar_with_hook_content_should_not_be_hidden (18.75s)
        Expected at least 1 element matching "div#sidebar p", found 0.
        Expected 0 to be >= 1.
        test/integration/lib/redmine/hook_test.rb:93:in `test_sidebar_with_hook_content_should_not_be_hidden'

 FAIL TwofaTest#test_should_allow_logout_even_if_twofa_setup_is_required (24.88s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/twofa_test.rb:102:in `block (2 levels) in <class:TwofaTest>'
        test/test_helper.rb:102:in `with_settings'
        test/integration/twofa_test.rb:94:in `block in <class:TwofaTest>'

 FAIL AdminTest#test_add_user (27.73s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/admin_test.rb:34:in `test_add_user'

 FAIL AccountTest#test_autologin (29.65s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/account_test.rb:77:in `block in test_autologin'
        test/test_helper.rb:102:in `with_settings'
        test/integration/account_test.rb:47:in `test_autologin'

 FAIL AccountTest#test_autologin_should_use_autologin_cookie_name (31.44s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/account_test.rb:109:in `block in 
test_autologin_should_use_autologin_cookie_name'
        test/test_helper.rb:102:in `with_settings'
        test/integration/account_test.rb:90:in `test_autologin_should_use_autologin_cookie_name'

 FAIL LayoutTest#test_help_and_powered_by_redmine_link_should_open_separate_tab (37.92s)
        Expected at least 1 element matching "#top-menu a.help[target=\"_blank\"][rel=\"noopener\"]", found 0.
        Expected 0 to be >= 1.
        test/integration/layout_test.rb:133:in `test_help_and_powered_by_redmine_link_should_open_separate_tab'

 FAIL LayoutTest#test_top_menu_and_search_visible_when_login_not_required (39.49s)
        Expected at least 1 element matching "#top-menu > ul", found 0.
        Expected 0 to be >= 1.
        test/integration/layout_test.rb:59:in `block in test_top_menu_and_search_visible_when_login_not_required'
        test/test_helper.rb:102:in `with_settings'
        test/integration/layout_test.rb:57:in `test_top_menu_and_search_visible_when_login_not_required'

 FAIL LayoutTest#test_search_field_outside_project_should_link_to_global_search (39.95s)
        Expected at least 1 element matching "div#quick-search form[action=\"/search\"]", found 0.
        Expected 0 to be >= 1.
        test/integration/layout_test.rb:123:in `test_search_field_outside_project_should_link_to_global_search'

 FAIL SudoModeTest#test_add_user (40.56s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/sudo_mode_test.rb:41:in `test_add_user'

 FAIL SudoModeTest#test_create_member_xhr (41.05s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/sudo_mode_test.rb:81:in `test_create_member_xhr'

 FAIL SudoModeTest#test_create_role (41.56s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/sudo_mode_test.rb:131:in `test_create_role'

 FAIL SudoModeTest#test_sudo_mode_should_be_active_after_login (42.11s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/sudo_mode_test.rb:19:in `test_sudo_mode_should_be_active_after_login'

 FAIL SudoModeTest#test_create_member (42.56s)
        Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
        test/integration/sudo_mode_test.rb:105:in `test_create_member'
Actions
Copy link
 #1

Updated by liaham 9 months ago

  • Subject changed from Fix broken controller tests to Fix broken integration tests
  • Target version changed from unplanned to 4.3.0
  • % Done changed from 0 to 20
Actions
Copy link
 #2

Updated by liaham 9 months ago

  • Description updated (diff)
  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by liaham 9 months ago

  • test_archive_project
  • test_add_user
  • test_create_role
  • test_sudo_mode_should_be_active_after_login

fails due to

ActionView::Template::Error (No route matches {:action=>"index", :controller=>"project_types"}):
    1: <div id="admin-menu">
    2:   <%= render_menu :admin_menu %>
    3: </div>
  
lib/redmine/menu_manager.rb:183:in `render_single_menu_node'
lib/redmine/menu_manager.rb:127:in `render_menu_node'
lib/redmine/menu_manager.rb:116:in `block in render_menu'
lib/redmine/menu_manager.rb:199:in `block in menu_items_for'
lib/redmine/menu_manager.rb:196:in `each'
lib/redmine/menu_manager.rb:196:in `menu_items_for'
lib/redmine/menu_manager.rb:115:in `render_menu'
Actions
Copy link
 #4

Updated by liaham 9 months ago

  • test_empty_sidebar_should_be_hidden
  • test_sidebar_with_hook_content_should_not_be_hidden
  • test_help_and_powered_by_redmine_link_should_open_separate_tab
  • test_top_menu_and_search_visible_when_login_not_required
  • test_search_field_outside_project_should_link_to_global_search
  • test_body_should_have_main_menu_css_class_if_main_menu_is_present

fails due to

ActionView::Template::Error (undefined method `order_blocks_dashboard_path' for #<ActionView::Base:0x00000000077e48>):
    82:         // trigger the call on the list that receives the block only
    83:         if ($(this).find(ui.item).length > 0) {
    84:           $.ajax({
    85:             url: "<%= escape_javascript order_blocks_dashboard_path(dashboard) %>",
    86:             type: 'post',
    87:             data: {
    88:               'group': $(this).attr('id').replace(/^list-/, ''),
  
plugins/redmine_dashboards/app/views/common/_dashboard.html.erb:85
plugins/redmine_dashboards/app/views/common/_dashboard.html.erb:54
plugins/redmine_dashboards/app/views/welcome/index.html.erb:65
Actions
Copy link
 #5

Updated by liaham 9 months ago

  • test_autologin
  • test_autologin_should_use_autologin_cookie_name

fails due to

ActionView::Template::Error (No route matches {:action=>"index", :controller=>"dmsf"}):
    71:   image_tag('logo-icon.png', plugin: 'xmera_omnia_operations', width: '35px', height: '35px'),
    72:   id: 'branding' -%>
    73:     <div id="account">
    74:         <%= render_menu :account_menu -%>
    75:     </div>
    76:     <%= content_tag('div', "#{l(:label_logged_as)} #{link_to_user(User.current, :format => :username)}".html_safe, :id => 'loggedas') if User.current.logged? %>
    77:     <%= render_menu :top_menu if User.current.logged? || !Setting.login_required? -%>
  
lib/redmine/menu_manager.rb:183:in `render_single_menu_node'
lib/redmine/menu_manager.rb:127:in `render_menu_node'
lib/redmine/menu_manager.rb:116:in `block in render_menu'
lib/redmine/menu_manager.rb:199:in `block in menu_items_for'
lib/redmine/menu_manager.rb:196:in `each'
lib/redmine/menu_manager.rb:196:in `menu_items_for'
lib/redmine/menu_manager.rb:115:in `render_menu'
app/views/layouts/base.html.erb:74
Actions
Copy link
 #6

Updated by liaham 9 months ago

  • test_create_member_xhr
  • test_create_member

fails due to

ActionView::Template::Error (No route matches {:action=>"index", :controller=>"dmsf", :id=>"ecookbook", :tab=>"members"}):
    71:   image_tag('logo-icon.png', plugin: 'xmera_omnia_operations', width: '35px', height: '35px'),
    72:   id: 'branding' -%>
    73:     <div id="account">
    74:         <%= render_menu :account_menu -%>
    75:     </div>
    76:     <%= content_tag('div', "#{l(:label_logged_as)} #{link_to_user(User.current, :format => :username)}".html_safe, :id => 'loggedas') if User.current.logged? %>
    77:     <%= render_menu :top_menu if User.current.logged? || !Setting.login_required? -%>
  
lib/redmine/menu_manager.rb:183:in `render_single_menu_node'
lib/redmine/menu_manager.rb:127:in `render_menu_node'
lib/redmine/menu_manager.rb:116:in `block in render_menu'
lib/redmine/menu_manager.rb:199:in `block in menu_items_for'
lib/redmine/menu_manager.rb:196:in `each'
lib/redmine/menu_manager.rb:196:in `menu_items_for'
lib/redmine/menu_manager.rb:115:in `render_menu'
Actions
Copy link
 #7

Updated by liaham 9 months ago

The test problems occur due to test/integration/routing/plugin_test.rb added in RM 5.1.0 38707.

Our test tool considers this issue now.

Nothing to fix on the plugins code!

Actions
Copy link
 #8

Updated by liaham 9 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 20 to 100
Actions
Copy link

Also available in: Atom PDF