Redmine

In Redmine::NestedSet::ProjectNestedSet#target_lft the code could be improved like this:

      def target_lft
        return 1 unless parent_id.to_i.positive? # <-- Using guard clause

        siblings_rgt =
          self.class.where(:parent_id => parent_id).where("name < ?", name).maximum(:rgt)
        if siblings_rgt
          siblings_rgt + 1
        elsif parent_id
          parent_lft = self.class.where(:id => parent_id).pick(:lft)
          unless parent_lft
            raise "Project id=#{id} with parent_id=#{parent_id}: parent missing or without 'lft' value"
          end

          parent_lft + 1
        else
          1
        end
      end

Using parent_id.to_i transforms like this:

• nil -> 0
• 0 -> 0
• an integer value greater zero -> an integer value greater zero
• any String value -> to any integer value greater zero or zero for anything else